Lowercase the doctype #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change adds an unnecessary newline. |
|
Fixed, thank you |
|
It is still there. |
|
Sorry, fixed again using file upload |
|
Requesting review again, please |
alrra
reviewed
Mar 9, 2021
| <!doctype html> |
There was a problem hiding this comment.
You can even remove the space.
Suggested change
| <!doctype html> | |
| <!doctypehtml> |
There was a problem hiding this comment.
The whitespace is required
Source:
https://html.spec.whatwg.org/multipage/syntax.html#the-doctype
A DOCTYPE must consist of the following components, in this order:
- A string that is an ASCII case-insensitive match for the string "<!DOCTYPE".
- One or more ASCII whitespace. ⭐
- A string that is an ASCII case-insensitive match for the string "html".
- Optionally, a DOCTYPE legacy string.
- Zero or more ASCII whitespace.
- A U+003E GREATER-THAN SIGN character (>).
mathiasbynens
force-pushed
the
master
branch
from
e0d540b
to
735df1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace every DOCTYPE to doctype.
Best practice identified at https://stackoverflow.com/questions/7020961/uppercase-or-lowercase-doctype#comment71796606_7020961
The achieves not only being the same size as the existing file in the repository, but, because of GZIP compression, this is likely to be smaller when sent across the network wire, up to possibly a FULL BYTE!